[SPARK-46926][PS][CONNECT] Support convert_dtypes and infer_objects in fallback mode#44959
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-46926][PS][CONNECT] Support convert_dtypes and infer_objects in fallback mode#44959zhengruifeng wants to merge 2 commits intoapache:masterfrom
convert_dtypes and infer_objects in fallback mode#44959zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
Jan 31, 2024
| "asfreq", | ||
| "asof", | ||
| "convert_dtypes", | ||
| "infer_objects", |
Member
There was a problem hiding this comment.
I think we should add them all for fallback for now without a couple of tests instead of adding each API here with each test cases because we can add the tests in the future, and ideally we should implement all API
Contributor
Author
There was a problem hiding this comment.
sg, let me add them in another PR.
Contributor
Author
|
spark uses partial data to infer the schema, and warns in this case ( |
Member
|
Let's leave it with warning for now |
HyukjinKwon
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
convert_dtypesandinfer_objectsin fallback modeWhy are the changes needed?
for parity
Does this PR introduce any user-facing change?
new functions support in fallback mode, disabled by default
How was this patch tested?
added ut
Was this patch authored or co-authored using generative AI tooling?
no