Skip to content

[SPARK-46953][TEST]] Wrap withTable for a test in ResolveDefaultColumnsSuite #44993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 1 commit into from
Closed

[SPARK-46953][TEST]] Wrap withTable for a test in ResolveDefaultColumnsSuite #44993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 53 additions & 51 deletions sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,57 +76,59 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
}

test("INSERT into partitioned tables") {
sql("create table t(c1 int, c2 int, c3 int, c4 int) using parquet partitioned by (c3, c4)")

// INSERT without static partitions
checkError(
exception = intercept[AnalysisException] {
sql("insert into t values (1, 2, 3)")
},
errorClass = "INSERT_COLUMN_ARITY_MISMATCH.NOT_ENOUGH_DATA_COLUMNS",
parameters = Map(
"tableName" -> "`spark_catalog`.`default`.`t`",
"tableColumns" -> "`c1`, `c2`, `c3`, `c4`",
"dataColumns" -> "`col1`, `col2`, `col3`"))

// INSERT without static partitions but with column list
sql("truncate table t")
sql("insert into t (c2, c1, c4) values (1, 2, 3)")
checkAnswer(spark.table("t"), Row(2, 1, null, 3))

// INSERT with static partitions
sql("truncate table t")
checkError(
exception = intercept[AnalysisException] {
sql("insert into t partition(c3=3, c4=4) values (1)")
},
errorClass = "INSERT_PARTITION_COLUMN_ARITY_MISMATCH",
parameters = Map(
"tableName" -> "`spark_catalog`.`default`.`t`",
"tableColumns" -> "`c1`, `c2`, `c3`, `c4`",
"dataColumns" -> "`col1`",
"staticPartCols" -> "`c3`, `c4`"))

// INSERT with static partitions and with column list
sql("truncate table t")
sql("insert into t partition(c3=3, c4=4) (c2) values (1)")
checkAnswer(spark.table("t"), Row(null, 1, 3, 4))

// INSERT with partial static partitions
sql("truncate table t")
checkError(
exception = intercept[AnalysisException] {
sql("insert into t partition(c3=3, c4) values (1, 2)")
},
errorClass = "INSERT_PARTITION_COLUMN_ARITY_MISMATCH",
parameters = Map(
"tableName" -> "`spark_catalog`.`default`.`t`",
"tableColumns" -> "`c1`, `c2`, `c3`, `c4`",
"dataColumns" -> "`col1`, `col2`",
"staticPartCols" -> "`c3`"))

// INSERT with partial static partitions and with column list is not allowed
intercept[AnalysisException](sql("insert into t partition(c3=3, c4) (c1) values (1, 4)"))
withTable("t") {
sql("create table t(c1 int, c2 int, c3 int, c4 int) using parquet partitioned by (c3, c4)")

// INSERT without static partitions
checkError(
exception = intercept[AnalysisException] {
sql("insert into t values (1, 2, 3)")
},
errorClass = "INSERT_COLUMN_ARITY_MISMATCH.NOT_ENOUGH_DATA_COLUMNS",
parameters = Map(
"tableName" -> "`spark_catalog`.`default`.`t`",
"tableColumns" -> "`c1`, `c2`, `c3`, `c4`",
"dataColumns" -> "`col1`, `col2`, `col3`"))

// INSERT without static partitions but with column list
sql("truncate table t")
sql("insert into t (c2, c1, c4) values (1, 2, 3)")
checkAnswer(spark.table("t"), Row(2, 1, null, 3))

// INSERT with static partitions
sql("truncate table t")
checkError(
exception = intercept[AnalysisException] {
sql("insert into t partition(c3=3, c4=4) values (1)")
},
errorClass = "INSERT_PARTITION_COLUMN_ARITY_MISMATCH",
parameters = Map(
"tableName" -> "`spark_catalog`.`default`.`t`",
"tableColumns" -> "`c1`, `c2`, `c3`, `c4`",
"dataColumns" -> "`col1`",
"staticPartCols" -> "`c3`, `c4`"))

// INSERT with static partitions and with column list
sql("truncate table t")
sql("insert into t partition(c3=3, c4=4) (c2) values (1)")
checkAnswer(spark.table("t"), Row(null, 1, 3, 4))

// INSERT with partial static partitions
sql("truncate table t")
checkError(
exception = intercept[AnalysisException] {
sql("insert into t partition(c3=3, c4) values (1, 2)")
},
errorClass = "INSERT_PARTITION_COLUMN_ARITY_MISMATCH",
parameters = Map(
"tableName" -> "`spark_catalog`.`default`.`t`",
"tableColumns" -> "`c1`, `c2`, `c3`, `c4`",
"dataColumns" -> "`col1`, `col2`",
"staticPartCols" -> "`c3`"))

// INSERT with partial static partitions and with column list is not allowed
intercept[AnalysisException](sql("insert into t partition(c3=3, c4) (c1) values (1, 4)"))
}
}

test("SPARK-43085: Column DEFAULT assignment for target tables with multi-part names") {
Expand Down