[SPARK-46956][SQL] Improve the error prompt when SaveMode is null in API DataFrameWriter.mode#44999
Closed
panbingkun wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-46956][SQL] Improve the error prompt when SaveMode is null in API DataFrameWriter.mode#44999panbingkun wants to merge 3 commits intoapache:masterfrom
SaveMode is null in API DataFrameWriter.mode#44999panbingkun wants to merge 3 commits intoapache:masterfrom
Conversation
…n API `DataFrameWriter.mode`
MaxGekk
reviewed
Feb 3, 2024
| """{ | ||
| | "errorClass" : "UNSUPPORTED_SAVE_MODE.EXISTENT_PATH", | ||
| | "messageTemplate" : "The save mode <saveMode> is not supported for: an existent path.", | ||
| | "messageTemplate" : "The save mode <saveMode> is not supported. for an existent path.", |
Member
There was a problem hiding this comment.
This supported. for an looks weird. Could you improve the error message.
Contributor
Author
There was a problem hiding this comment.
Okay, let me think about it carefully.
…API DataFrameWriter.mode
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to improve the
error promptwhenSaveMode is nullin APIDataFrameWriter.mode.Why are the changes needed?
When
mode is nullin APIDataFrameWriter.mode, the prompt information is more reasonable and will not cause misunderstandings.Before:
After:
Does this PR introduce any user-facing change?
Yes, make more reasonable error prompts to reduce misunderstandings.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.