[SPARK-46976][PS] Implement DataFrameGroupBy.corr#45028
Closed
zhengruifeng wants to merge 6 commits into
Closed
Conversation
HyukjinKwon
approved these changes
Feb 5, 2024
xinrong-meng
reviewed
Feb 5, 2024
| 2 B NaN NaN | ||
| C NaN NaN | ||
|
|
||
| >>> psdf.groupby("A").corr(min_periods=2) |
Member
|
LGTM after fixing the typo in doctest, thanks! |
Contributor
Author
|
thanks for the reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement
DataFrameGroupBy.corrWhy are the changes needed?
for pandas parity
https://pandas.pydata.org/docs/reference/api/pandas.core.groupby.DataFrameGroupBy.corr.html
Does this PR introduce any user-facing change?
yes
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no