Skip to content

[SPARK-47023][BUILD] Upgrade aircompressor to 0.26#45084

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-47023
Closed

[SPARK-47023][BUILD] Upgrade aircompressor to 0.26#45084
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-47023

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 12, 2024

What changes were proposed in this pull request?

This PR aims to upgrade aircompressor to 0.26.

Why are the changes needed?

aircompressor v0.26 has the following bug fixes.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Feb 12, 2024
</dependency>
<dependency>
<groupId>io.airlift</groupId>
<artifactId>aircompressor</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why we need to bring a new dependency for this: where is the old dependency (aircompressor 0.25) come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, it came from Apache ORC library.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Parquet also has some dependency.

However, I'm not sure about Parquet part. This PR aims to override it from Apache Spark side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @sunchao !

If new libraries come in the future, we will remove this override back.

@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-47023 branch February 12, 2024 18:38
dongjoon-hyun added a commit that referenced this pull request Feb 13, 2024
This PR aims to upgrade `aircompressor` to 1.26.

`aircompressor` v1.26 has the following bug fixes.

- [Fix out of bounds read/write in Snappy decompressor](airlift/aircompressor@b89db18)
- [Fix ZstdOutputStream corruption on double close](airlift/aircompressor@b89db18)

No.

Pass the CIs.

No.

Closes #45084 from dongjoon-hyun/SPARK-47023.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member Author

Since the RC1 vote fails, I backported this to branch-3.5.

@HeartSaVioR HeartSaVioR changed the title [SPARK-47023][BUILD] Upgrade aircompressor to 1.26 [SPARK-47023][BUILD] Upgrade aircompressor to 0.26 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants