Skip to content

[SPARK-47027][PYTHON][TESTS] Use temporary directories for profiler test outputs#45087

Closed
ueshin wants to merge 1 commit intoapache:masterfrom
ueshin:issues/SPARK-47027/tempdir
Closed

[SPARK-47027][PYTHON][TESTS] Use temporary directories for profiler test outputs#45087
ueshin wants to merge 1 commit intoapache:masterfrom
ueshin:issues/SPARK-47027/tempdir

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Feb 12, 2024

What changes were proposed in this pull request?

Use temporary directories for profiler test outputs instead of tempfile.gettempdir().

Why are the changes needed?

Directly using tempfile.gettempdir() can leave the files there after each test.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Thank you, @ueshin . Merged to master.

@xinrong-meng
Copy link
Member

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants