[SPARK-47039][TESTS] Add a checkstyle rule to ban commons-lang in Java code#45097
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47039][TESTS] Add a checkstyle rule to ban commons-lang in Java code#45097dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
commons-lang in Java code#45097dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
dongjoon-hyun
changed the title
commons-lang2 in Java codecommons-lang in Java code
Member
Author
|
All tests passed.
|
Member
Author
|
Could you review this PR, please, @huaxingao ? |
huaxingao
approved these changes
Feb 14, 2024
Contributor
|
LGTM. Thanks for the PR! |
Member
Author
|
Thank you so much, @huaxingao ! Merged to master. |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
…ava code This PR aims to add a checkstyle rule to ban `commons-lang` in Java code in favor of `commons-lang3`. SPARK-16129 banned `commons-lang` in Scala code since Apache Spark 2.0.0. No. Pass the CIs. No. Closes apache#45097 from dongjoon-hyun/SPARK-47039. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add a checkstyle rule to ban
commons-langin Java code in favor ofcommons-lang3.Why are the changes needed?
SPARK-16129 banned
commons-langin Scala code since Apache Spark 2.0.0.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.