[SPARK-47056][TESTS] Add scalastyle and checkstyle rules to ban FileBackedOutputStream#45116
Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-47056][TESTS] Add scalastyle and checkstyle rules to ban FileBackedOutputStream#45116dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
scalastyle and checkstyle rules to ban FileBackedOutputStream#45116dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
Conversation
…BackedOutputStream`
HyukjinKwon
approved these changes
Feb 15, 2024
Member
Author
|
Thank you, @HyukjinKwon ! |
Member
Author
|
Scala and Java linters passed. Merged to master.
|
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
…FileBackedOutputStream` This PR aims to add `scalastyle` and `checkstyle` rules to ban `FileBackedOutputStream`. We don't use this but this will explicitly prevent any accidental usage of `FileBackedOutputStream` in the future. No. Pass the CIs. No. Closes apache#45116 from dongjoon-hyun/SPARK-47056. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
scalastyleandcheckstylerules to banFileBackedOutputStream.Why are the changes needed?
We don't use this but this will explicitly prevent any accidental usage of
FileBackedOutputStreamin the future.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.