Skip to content

[SPARK-42285][DOC] Update Parquet data source doc on the timestamp_ntz inference option#45145

Closed
gengliangwang wants to merge 1 commit intoapache:masterfrom
gengliangwang:changeConfigName
Closed

[SPARK-42285][DOC] Update Parquet data source doc on the timestamp_ntz inference option#45145
gengliangwang wants to merge 1 commit intoapache:masterfrom
gengliangwang:changeConfigName

Conversation

@gengliangwang
Copy link
Member

@gengliangwang gengliangwang commented Feb 16, 2024

What changes were proposed in this pull request?

This is a follow-up of #39856. The configuration changes should be reflected in the Parquet data source doc

Why are the changes needed?

To fix doc

Does this PR introduce any user-facing change?

No

How was this patch tested?

Preview:
image

Was this patch authored or co-authored using generative AI tooling?

No

<td>3.3.0</td>
</tr>
<tr>
<td><code>spark.sql.parquet.timestampNTZ.enabled</code></td>
Copy link
Member

@dongjoon-hyun dongjoon-hyun Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, previous this was no-op because Spark has no this configuration name, @gengliangwang ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you!

@dongjoon-hyun
Copy link
Member

BTW, did you upload the screenshot? The link seems to be broken, @gengliangwang .

Screenshot 2024-02-16 at 15 35 57

@gengliangwang
Copy link
Member Author

@dongjoon-hyun Yes, the screenshot is just updated.

@gengliangwang
Copy link
Member Author

Merging to master/branch-3.5. @dongjoon-hyun Thanks for the review.

gengliangwang added a commit that referenced this pull request Feb 17, 2024
…z inference option

### What changes were proposed in this pull request?

This is a follow-up of #39856. The configuration changes should be reflected in the Parquet data source doc

### Why are the changes needed?

To fix doc
### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Preview:
<img width="1010" alt="image" src="https://github.com/apache/spark/assets/1097932/618df731-49ad-49e7-afa2-22381cb3bbef">

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #45145 from gengliangwang/changeConfigName.

Authored-by: Gengliang Wang <gengliang@apache.org>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit dc2f267)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments