[SPARK-47089][BUILD][TESTS] Migrate mockito 4 to mockito 5#45158
Closed
panbingkun wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-47089][BUILD][TESTS] Migrate mockito 4 to mockito 5#45158panbingkun wants to merge 3 commits intoapache:masterfrom
mockito 4 to mockito 5#45158panbingkun wants to merge 3 commits intoapache:masterfrom
Conversation
panbingkun
changed the title
mockito 4 to mockito 5mockito 4 to mockito 5
Contributor
Author
panbingkun
commented
Feb 19, 2024
| when(podsWithNamespace.withName(driverPodName)).thenReturn(driverPodOperations) | ||
| when(podsWithNamespace.resource(any())).thenReturn(podResource) | ||
| when(podsWithNamespace.withLabel(anyString(), anyString())).thenReturn(labeledPods) | ||
| when(podsWithNamespace.withLabelIn(anyString(), any())).thenReturn(labeledPods) |
dongjoon-hyun
approved these changes
Feb 19, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Oh, thank you so much, @panbingkun . It looks good to me.
Member
|
Merged to master for Apache Spark 4.0.0. |
Contributor
|
late LGTM ~ thanks @panbingkun and @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to migrate
mockito 4tomockito 5.Why are the changes needed?
This is the prerequisite behavior for upgrading
scalatest mockitoto version3.2.18.Scalatest mockito 3.2.18no longer supportsmockito 4.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.