[SPARK-47108][CORE] Set derby.connection.requireAuthentication to false explicitly in CLIs#45185
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47108][CORE] Set derby.connection.requireAuthentication to false explicitly in CLIs#45185dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
derby.connection.requireAuthentication to false explicitly in CLIs#45185dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
…alse explicitly in CLIs
HyukjinKwon
approved these changes
Feb 20, 2024
Member
Author
|
Thank you, @HyukjinKwon . Merged to master for Apache Spark 4.0.0. |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
…false` explicitly in CLIs ### What changes were proposed in this pull request? This PR aims to set `derby.connection.requireAuthentication` to `false` explicitly in CLIs by adding an option at `SparkSubmitCommandBuilder`. ### Why are the changes needed? Not that the embedded `Apache Derby` is supposed to be used in a non-production environment only. However, it's used (or exposed) to the users when there is no reachable Hive MetaStores. For example, `spark-shell` and `spark-sql` and `Spark ThriftServer`. https://github.com/apache/spark/blob/9d9675922543e3e5c3b01023e5a756462a1fd308/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L190 Although `derby.connection.requireAuthentication` is supposed to be `false` by default in Apache Derby, this PR aims to make it sure that Apache Spark doesn't use it always intentionally. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45185 from dongjoon-hyun/SPARK-47108. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to set
derby.connection.requireAuthenticationtofalseexplicitly in CLIs by adding an option atSparkSubmitCommandBuilder.Why are the changes needed?
Not that the embedded
Apache Derbyis supposed to be used in a non-production environment only. However, it's used (or exposed) to the users when there is no reachable Hive MetaStores. For example,spark-shellandspark-sqlandSpark ThriftServer.spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Line 190 in 9d96759
Although
derby.connection.requireAuthenticationis supposed to befalseby default in Apache Derby, this PR aims to make it sure that Apache Spark doesn't use it always intentionally.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.