[SPARK-47115][INFRA][FOLLOW-UP] Use larger runner for Maven build (macos-14-large)#45211
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47115][INFRA][FOLLOW-UP] Use larger runner for Maven build (macos-14-large)#45211HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Sorry @dongjoon-hyun it's my bad. I think we should better use a larger runner. |
Member
|
No problem at all. It was a nice try to validate all combinations, @HyukjinKwon :) |
dongjoon-hyun
changed the title
Member
|
Merged to master~ |
Member
Author
|
|
Member
|
Thank you for reverting. |
Member
|
Are we going to revert the original, #45195 ? |
Member
Author
|
Sure will do ... |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…cos-14-large) ### What changes were proposed in this pull request? This PR addresses apache#45195 (review) by using larger runner. However, I do not change the memory at `.github/workflows/maven_test.yml` because that is shared by other standard runners. We're using GitHub Enterprise so this runners are available. ### Why are the changes needed? It still fails https://github.com/apache/spark/actions/runs/7994847558. My speculation is that it relates to the resources available. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will monitor the scheduled jobs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45211 from HyukjinKwon/SPARK-47115-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses #45195 (review) by using larger runner.
However, I do not change the memory at
.github/workflows/maven_test.ymlbecause that is shared by other standard runners.We're using GitHub Enterprise so this runners are available.
Why are the changes needed?
It still fails https://github.com/apache/spark/actions/runs/7994847558. My speculation is that it relates to the resources available.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Will monitor the scheduled jobs.
Was this patch authored or co-authored using generative AI tooling?
No.