[SPARK-47159][INFRA] Set OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES in MacOS GitHub Action Job#45249
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47159][INFRA] Set OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES in MacOS GitHub Action Job#45249dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES in MacOS GitHub Action Job#45249dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
… `MacOS` GitHub Action Job
Member
|
Merged to master. |
Member
Author
|
Thank you, @HyukjinKwon ! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
… `MacOS` GitHub Action Job ### What changes were proposed in this pull request? This PR aims to set `OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES` in `MacOS` GitHub Action Job. - https://github.com/apache/spark/actions/workflows/build_maven_java21_macos14.yml ### Why are the changes needed? This is recommended for Python tests, but it seems that `Spark Connect` Python test suites are also related. We had better have this to be safe or isolate any issue. https://github.com/apache/spark/blob/0ff18e579c2f4fc31f825a4acaea529b3d03945d/python/docs/source/development/testing.rst?plain=1#L39 ### Does this PR introduce _any_ user-facing change? No, this is a test infra-only change. ### How was this patch tested? Manual review. This is tested by Daily CI after merging. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45249 from dongjoon-hyun/SPARK-47159. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to set
OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YESinMacOSGitHub Action Job.Why are the changes needed?
This is recommended for Python tests, but it seems that
Spark ConnectPython test suites are also related. We had better have this to be safe or isolate any issue.spark/python/docs/source/development/testing.rst
Line 39 in 0ff18e5
Does this PR introduce any user-facing change?
No, this is a test infra-only change.
How was this patch tested?
Manual review. This is tested by Daily CI after merging.
Was this patch authored or co-authored using generative AI tooling?
No.