Skip to content

[SPARK-47178][PYTHON][TESTS] Add a test case for createDataFrame with dataclasses#45271

Closed
HyukjinKwon wants to merge 3 commits into
apache:masterfrom
HyukjinKwon:SPARK-47178
Closed

[SPARK-47178][PYTHON][TESTS] Add a test case for createDataFrame with dataclasses#45271
HyukjinKwon wants to merge 3 commits into
apache:masterfrom
HyukjinKwon:SPARK-47178

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR adds a test case for dataclasses with createDataFrame that is already supported:

from dataclasses import dataclass

@dataclass
class User:
    name: str
    age: int
    is_active: bool

user = User(name="John", age=30, is_active=True)
spark.createDataFrame([user]).show()

Why are the changes needed?

To make sure dataclasses work with PySpark.

Does this PR introduce any user-facing change?

No, test-only

How was this patch tested?

Added test case.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon HyukjinKwon changed the title [SPARK-47178][PYTHON][TESTS]Add a test case for createDataFrame with dataclasses [SPARK-47178][PYTHON][TESTS] Add a test case for createDataFrame with dataclasses Feb 27, 2024
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon
Copy link
Copy Markdown
Member Author

Merged to master.

TakawaAkirayo pushed a commit to TakawaAkirayo/spark that referenced this pull request Mar 4, 2024
… dataclasses

### What changes were proposed in this pull request?

This PR adds a test case for dataclasses with createDataFrame that is already supported:

```python
from dataclasses import dataclass

dataclass
class User:
    name: str
    age: int
    is_active: bool

user = User(name="John", age=30, is_active=True)
spark.createDataFrame([user]).show()
```

### Why are the changes needed?

To make sure dataclasses work with PySpark.

### Does this PR introduce _any_ user-facing change?

No, test-only

### How was this patch tested?

Added test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45271 from HyukjinKwon/SPARK-47178.

Lead-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Co-authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ericm-db pushed a commit to ericm-db/spark that referenced this pull request Mar 5, 2024
… dataclasses

### What changes were proposed in this pull request?

This PR adds a test case for dataclasses with createDataFrame that is already supported:

```python
from dataclasses import dataclass

dataclass
class User:
    name: str
    age: int
    is_active: bool

user = User(name="John", age=30, is_active=True)
spark.createDataFrame([user]).show()
```

### Why are the changes needed?

To make sure dataclasses work with PySpark.

### Does this PR introduce _any_ user-facing change?

No, test-only

### How was this patch tested?

Added test case.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45271 from HyukjinKwon/SPARK-47178.

Lead-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Co-authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants