Skip to content

[SPARK-47181][CORE][TESTS] Fix MasterSuite to validate the number of registered workers#45274

Closed
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-47181
Closed

[SPARK-47181][CORE][TESTS] Fix MasterSuite to validate the number of registered workers#45274
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-47181

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Feb 27, 2024

What changes were proposed in this pull request?

This PR aims to fix MasterSuite to validate the number of registered workers during SPARK-46881: scheduling with workerSelectionPolicy * tests.

Why are the changes needed?

To fix a flakiness.

[info] - SPARK-46881: scheduling with workerSelectionPolicy - CORES_FREE_DESC (false) *** FAILED *** (178 milliseconds)
[info]   List("10004") did not equal List("10005") (MasterSuite.scala:728)
[info]   Analysis:
[info]   List(0: "10004" -> "10005")

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

cc @HyukjinKwon

Copy link
Copy Markdown
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @yaooqinn , @HyukjinKwon , @viirya .
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-47181 branch February 27, 2024 04:28
TakawaAkirayo pushed a commit to TakawaAkirayo/spark that referenced this pull request Mar 4, 2024
…f registered workers

### What changes were proposed in this pull request?

This PR aims to fix `MasterSuite` to validate the number of registered workers during `SPARK-46881: scheduling with workerSelectionPolicy *` tests.

### Why are the changes needed?

To fix a flakiness.
- https://github.com/apache/spark/actions/runs/8042308713/job/21962794853#step:10:17224

```
[info] - SPARK-46881: scheduling with workerSelectionPolicy - CORES_FREE_DESC (false) *** FAILED *** (178 milliseconds)
[info]   List("10004") did not equal List("10005") (MasterSuite.scala:728)
[info]   Analysis:
[info]   List(0: "10004" -> "10005")
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45274 from dongjoon-hyun/SPARK-47181.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
ericm-db pushed a commit to ericm-db/spark that referenced this pull request Mar 5, 2024
…f registered workers

### What changes were proposed in this pull request?

This PR aims to fix `MasterSuite` to validate the number of registered workers during `SPARK-46881: scheduling with workerSelectionPolicy *` tests.

### Why are the changes needed?

To fix a flakiness.
- https://github.com/apache/spark/actions/runs/8042308713/job/21962794853#step:10:17224

```
[info] - SPARK-46881: scheduling with workerSelectionPolicy - CORES_FREE_DESC (false) *** FAILED *** (178 milliseconds)
[info]   List("10004") did not equal List("10005") (MasterSuite.scala:728)
[info]   Analysis:
[info]   List(0: "10004" -> "10005")
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45274 from dongjoon-hyun/SPARK-47181.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Mar 26, 2024
…f registered workers

### What changes were proposed in this pull request?

This PR aims to fix `MasterSuite` to validate the number of registered workers during `SPARK-46881: scheduling with workerSelectionPolicy *` tests.

### Why are the changes needed?

To fix a flakiness.
- https://github.com/apache/spark/actions/runs/8042308713/job/21962794853#step:10:17224

```
[info] - SPARK-46881: scheduling with workerSelectionPolicy - CORES_FREE_DESC (false) *** FAILED *** (178 milliseconds)
[info]   List("10004") did not equal List("10005") (MasterSuite.scala:728)
[info]   Analysis:
[info]   List(0: "10004" -> "10005")
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45274 from dongjoon-hyun/SPARK-47181.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants