[SPARK-47279][CORE]When the messageLoop encounter a fatal exception, such as oom, exit the JVM to avoid the driver hanging forever#45385
Closed
lastbus wants to merge 4 commits intoapache:branch-3.5from
Closed
Conversation
…such as oom, exit the JVM to avoid the driver hanging forever
Member
|
Instead of handling such a special case here, JVM has provided helpful arguments to deal with OutOfMemoryError. |
…such as oom, exit the JVM to avoid the driver hanging indefinitely
Contributor
+1 |
…such as oom, exit the JVM to avoid the driver hanging indefinitely
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a task has finished and sent messages back to the driver, but the driver cannot create new thread because of insufficient memory, then the driver will hangs indefinitely. In this situation, we choose to exit JVM.
In my opinion, the root cause is that the
OutOfMemoryErroris not being caught properly by the driver. The driver do nothave
Thread.setDefaultUncaughtExceptionHandler, so theoomthrown by theMessageLoopis not being handled.Why are the changes needed?
Fatal exception may cause the driver hangs indefinitely.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No