[MINOR][DOCS][SQL] Fix doc comment for coalescePartitions.parallelismFirst#45437
Closed
eejbyfeldt wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][DOCS][SQL] Fix doc comment for coalescePartitions.parallelismFirst#45437eejbyfeldt wants to merge 1 commit intoapache:masterfrom
eejbyfeldt wants to merge 1 commit intoapache:masterfrom
Conversation
This changes the second `true` to `false` to make the doc comment correct. A setting of false will mean to not prioritize parallism and that will leak less small tasks.
cloud-fan
reviewed
Mar 8, 2024
| "configured target size. This is to maximize the parallelism and avoid performance " + | ||
| "regressions when enabling adaptive query execution. It's recommended to set this " + | ||
| "config to true on a busy cluster to make resource utilization more efficient (not many " + | ||
| "config to false on a busy cluster to make resource utilization more efficient (not many " + |
Contributor
There was a problem hiding this comment.
good catch! It's recommended to flip the default value, so "false"
cloud-fan
approved these changes
Mar 8, 2024
yaooqinn
approved these changes
Mar 8, 2024
HyukjinKwon
approved these changes
Mar 11, 2024
Member
|
Merged to master. |
Contributor
Author
|
Realised that this doc comment is actually in 2 places: #45458 |
yaooqinn
pushed a commit
that referenced
this pull request
Mar 11, 2024
…First on sql-performance-tuning page We missed that this doc comment is duplicated while fixing it in #45437 ### What changes were proposed in this pull request? Documentation fix. ### Why are the changes needed? Current doc is wrong. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45458 from eejbyfeldt/fix-minor-doc-comment-on-parallism-first. Authored-by: Emil Ejbyfeldt <eejbyfeldt@liveintent.com> Signed-off-by: Kent Yao <yao@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the second
truetofalseto make the doc comment correct. A setting of false will mean to not prioritize parallism and that will lead to less small tasks. Seems like it incorrectness was introduced here: #44787What changes were proposed in this pull request?
Documentation fix.
Why are the changes needed?
Current doc is wrong.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No.