[SPARK-47364][CORE] Make PluginEndpoint warn when plugins reply for one-way message#45478
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47364][CORE] Make PluginEndpoint warn when plugins reply for one-way message#45478dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
PluginEndpoint warn when plugins reply for one-way message#45478dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
… one-way message
Contributor
|
Why move it to warn @dongjoon-hyun ? Was it causing some issues to help debug ? |
Member
Author
|
We want to higher the log level to enforce the developers to fix it instead of ignoring it. |
mridulm
approved these changes
Mar 12, 2024
Contributor
|
Sounds good, thanks for the change. |
Member
Author
|
Thank you, @mridulm . Merged to master for Apache Spark 4.0.0. |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
… one-way message ### What changes were proposed in this pull request? This PR aims to make `PluginEndpoint` warn when plugins reply for one-way message. ### Why are the changes needed? Previously, it logs `INFO` level messages. Sometimes, it look 66% driver INFO logs. We had better increase the log level to make the users fix the issues. ### Does this PR introduce _any_ user-facing change? No. Only a log level. ### How was this patch tested? Manually. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45478 from dongjoon-hyun/SPARK-47364. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
PluginEndpointwarn when plugins reply for one-way message.Why are the changes needed?
Previously, it logs
INFOlevel messages. Sometimes, it look 66% driver INFO logs. We had better increase the log level to make the users fix the issues.Does this PR introduce any user-facing change?
No. Only a log level.
How was this patch tested?
Manually.
Was this patch authored or co-authored using generative AI tooling?
No.