[SPARK-47538][BUILD] Remove commons-logging dependency#45687
Closed
dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-47538][BUILD] Remove commons-logging dependency#45687dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
commons-logging dependency#45687dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
https://slf4j.org/legacy.html#jclOverSLF4J
|
Member
Author
|
Thanks. Let me try that way, @pan3793 . |
commons-logging dependencycommons-logging dependency
commons-logging dependencycommons-logging dependency
30a8202 to
4cae0ba
Compare
dongjoon-hyun
commented
Mar 25, 2024
pom.xml
Outdated
Member
Author
There was a problem hiding this comment.
For the record, since Apache Hive 2.0.0 removed direct commons-logging dependency via HIVE-12237 Use slf4j as logging facade, we don't need this.
4cae0ba to
edc9ff6
Compare
pan3793
approved these changes
Mar 25, 2024
Member
Author
|
Thank you, @pan3793 . |
Member
Author
|
All tests passed. Could you review this dependency PR, @yaooqinn ? |
Member
|
Hi @dongjoon-hyun. We can also remove the lines from the NOTICE*/LICENSE*? |
Member
Author
|
Oh, thanks. Sure! |
HyukjinKwon
approved these changes
Mar 25, 2024
Member
Author
|
Thank you, @pan3793 , @yaooqinn , @HyukjinKwon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
commons-loggingdependency in favor ofjcl-over-slf4j.Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.