[SPARK-47685][SQL] Restore the support for Stream type in Dataset#groupBy#45811
Closed
LuciferYang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-47685][SQL] Restore the support for Stream type in Dataset#groupBy#45811LuciferYang wants to merge 2 commits intoapache:masterfrom
Stream type in Dataset#groupBy#45811LuciferYang wants to merge 2 commits intoapache:masterfrom
Conversation
LuciferYang
commented
Apr 2, 2024
| import RelationalGroupedDataset._ | ||
|
|
||
| private[this] def toDF(aggExprs: Seq[Expression]): DataFrame = { | ||
| @scala.annotation.nowarn("cat=deprecation") |
Contributor
Author
There was a problem hiding this comment.
Need to suppress the use of Stream
LuciferYang
commented
Apr 2, 2024
| } | ||
|
|
||
| test("SPARK-38221: group by `Stream` of complex expressions should not fail") { | ||
| @scala.annotation.nowarn("cat=deprecation") |
Contributor
Author
There was a problem hiding this comment.
Need to suppress the use of Stream
LuciferYang
commented
Apr 2, 2024
| } | ||
|
|
||
| test("SPARK-38221: group by stream of complex expressions should not fail") { | ||
| test("SPARK-45685: group by `LazyList` of complex expressions should not fail") { |
Contributor
Author
There was a problem hiding this comment.
This test case is essentially added in SPARK-45685, the test case has been renamed to make its description clearer
Contributor
Author
dongjoon-hyun
approved these changes
Apr 2, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs).
Thank you for finding and fixing the regression, @LuciferYang .
HyukjinKwon
approved these changes
Apr 2, 2024
zhengruifeng
approved these changes
Apr 2, 2024
Contributor
Author
|
Merged into master for Spark 4.0. Thanks @dongjoon-hyun @HyukjinKwon @zhengruifeng |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When I reviewed the changes in SPARK-45685, I found an old user case that is no longer supported:
Since this is a historical user usage, and although the
Streamtype has been deprecated after Scala 2.13.0, it has not been removed, so this PR restores the support forStreamtype inDataset#groupBy.Why are the changes needed?
Restore the support for
Streamtype inDataset#groupByDoes this PR introduce any user-facing change?
No
How was this patch tested?
Stream.Was this patch authored or co-authored using generative AI tooling?
No