Skip to content

[SPARK-47582][SQL] Migrate Catalyst logInfo with variables to structured logging framework#45866

Closed
dtenedor wants to merge 10 commits into
apache:masterfrom
dtenedor:catalyst-log-info
Closed

[SPARK-47582][SQL] Migrate Catalyst logInfo with variables to structured logging framework#45866
dtenedor wants to merge 10 commits into
apache:masterfrom
dtenedor:catalyst-log-info

Conversation

@dtenedor
Copy link
Copy Markdown
Contributor

@dtenedor dtenedor commented Apr 3, 2024

What changes were proposed in this pull request?

Migrate logInfo with variables of the Catalyst module to structured logging framework. This is part1 which transforms the logInfo entries of the following API

def logInfo(msg: => String): Unit

to

def logInfo(entry: LogEntry): Unit

Why are the changes needed?

To enhance Apache Spark's logging system by implementing structured logging.

Does this PR introduce any user-facing change?

Yes, Spark core logs will contain additional MDC

How was this patch tested?

Compiler and scala style checks, as well as code review.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions Bot added the SQL label Apr 3, 2024
@dtenedor dtenedor changed the title commit [SPARK-47582][SQL] Migrate Catalyst logInfo with variables to structured logging framework Apr 3, 2024
@dtenedor
Copy link
Copy Markdown
Contributor Author

dtenedor commented Apr 4, 2024

cc @gengliangwang

@dtenedor dtenedor requested a review from gengliangwang April 4, 2024 20:12
Comment thread common/utils/src/main/scala/org/apache/spark/internal/Logging.scala Outdated
@dtenedor dtenedor requested a review from gengliangwang April 4, 2024 22:23
Comment thread common/utils/src/main/scala/org/apache/spark/internal/Logging.scala Outdated
@dtenedor dtenedor requested a review from gengliangwang April 5, 2024 04:37
Comment thread common/utils/src/main/scala/org/apache/spark/internal/Logging.scala Outdated
Comment thread common/utils/src/main/scala/org/apache/spark/internal/Logging.scala Outdated
Comment thread common/utils/src/main/scala/org/apache/spark/internal/Logging.scala Outdated
@gengliangwang
Copy link
Copy Markdown
Member

LGTM except two minor comments

@dtenedor dtenedor requested a review from gengliangwang April 5, 2024 22:48
@gengliangwang
Copy link
Copy Markdown
Member

Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants