[SPARK-47582][SQL] Migrate Catalyst logInfo with variables to structured logging framework#45866
Closed
dtenedor wants to merge 10 commits into
Closed
[SPARK-47582][SQL] Migrate Catalyst logInfo with variables to structured logging framework#45866dtenedor wants to merge 10 commits into
dtenedor wants to merge 10 commits into
Conversation
Contributor
Author
Member
|
LGTM except two minor comments |
gengliangwang
approved these changes
Apr 5, 2024
Member
|
Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate logInfo with variables of the Catalyst module to structured logging framework. This is part1 which transforms the logInfo entries of the following API
to
Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
Yes, Spark core logs will contain additional MDC
How was this patch tested?
Compiler and scala style checks, as well as code review.
Was this patch authored or co-authored using generative AI tooling?
No