[SPARK-47590][SQL] Hive-thriftserver: Migrate logWarn with variables to structured logging framework#45923
Closed
itholic wants to merge 11 commits intoapache:masterfrom
Closed
[SPARK-47590][SQL] Hive-thriftserver: Migrate logWarn with variables to structured logging framework#45923itholic wants to merge 11 commits intoapache:masterfrom
itholic wants to merge 11 commits intoapache:masterfrom
Conversation
…to structured logging framework
Contributor
Author
|
cc @gengliangwang as you're working on Also cc @panbingkun @pan3793 |
Member
|
LGTM. Actually, there are lot of Java code copied from Hive in this module, I'm not sure if we want to do some refactoring to adapt the structured logging framework. |
panbingkun
reviewed
Apr 8, 2024
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
panbingkun
reviewed
Apr 8, 2024
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
panbingkun
reviewed
Apr 8, 2024
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
panbingkun
reviewed
Apr 8, 2024
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
panbingkun
reviewed
Apr 8, 2024
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
panbingkun
reviewed
Apr 8, 2024
...ver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2Listener.scala
Outdated
Show resolved
Hide resolved
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala
Outdated
Show resolved
Hide resolved
...ver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2Listener.scala
Outdated
Show resolved
Hide resolved
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
...e-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
Outdated
Show resolved
Hide resolved
...ver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2Listener.scala
Outdated
Show resolved
Hide resolved
…/thriftserver/SparkSQLCLIDriver.scala Co-authored-by: Gengliang Wang <gengliang@apache.org>
…/thriftserver/SparkSQLCLIDriver.scala Co-authored-by: Gengliang Wang <gengliang@apache.org>
…/thriftserver/ui/HiveThriftServer2Listener.scala Co-authored-by: Gengliang Wang <gengliang@apache.org>
gengliangwang
approved these changes
Apr 16, 2024
Member
|
Thanks, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate
logWarningwith variables of Hive-thriftserver module to structured logging framework.Why are the changes needed?
To improve the existing logging system by migrating into structured logging.
Does this PR introduce any user-facing change?
No API changes, but the SQL catalyst logs will contain MDC(Mapped Diagnostic Context) from now.
How was this patch tested?
Run Scala auto formatting and style check. Also the existing CI should pass.
Was this patch authored or co-authored using generative AI tooling?
No.