Skip to content

Comments

[SPARK-47795][K8S][DOCS] Supplement the doc of job schedule for K8S#45982

Closed
beliefer wants to merge 6 commits intoapache:masterfrom
beliefer:SPARK-47795
Closed

[SPARK-47795][K8S][DOCS] Supplement the doc of job schedule for K8S#45982
beliefer wants to merge 6 commits intoapache:masterfrom
beliefer:SPARK-47795

Conversation

@beliefer
Copy link
Contributor

What changes were proposed in this pull request?

This PR propose to supplement the doc of job schedule for K8S.

Why are the changes needed?

Spark document missing the description of job schedule for K8S.

Does this PR introduce any user-facing change?

'No'.
Just update document.

How was this patch tested?

Manual tests.

Was this patch authored or co-authored using generative AI tooling?

'No'.

@github-actions github-actions bot added the DOCS label Apr 10, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line change is irrelevant to K8s.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
Because the link is not accurate even if it was not related to K8S.
Do you want me revert it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please handle this separately, @beliefer .
As you know, I'm the release manager of Apache Spark 3.4.3 (for next Monday).
I can backport this fix to branch-3.4 as a part of Apache Spark 3.4.3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong to me because there is actually nothing to follow in the future work section. May I ask what do you want to say here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about In K8S mode, K8S doesn't support external shuffle service yet. ?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a required change, @beliefer?

@beliefer
Copy link
Contributor Author

Is this a required change, @beliefer?

I think we should add these document so as follows the other cluster mangers.

@beliefer
Copy link
Contributor Author

cc @yaooqinn @LuciferYang

@beliefer beliefer changed the title [SPARK-47795][DOC] Supplement the doc of job schedule for K8S [SPARK-47795][DOCS] Supplement the doc of job schedule for K8S Apr 10, 2024
@yaooqinn
Copy link
Member

I didn't even notice this page or section. The dropdown from the Navi Bar is enough for me.

Do we support scheduling jobs across applications? It's odd to me.

@yaooqinn
Copy link
Member

Nit: Use K8s instead of K8S, the former is the official abbreviation

@beliefer beliefer force-pushed the SPARK-47795 branch 2 times, most recently from d6486d5 to 09ecc74 Compare April 11, 2024 02:24
@beliefer
Copy link
Contributor Author

Do we support scheduling jobs across applications? It's odd to me.

This section is about scheduling across applications.
Scheduling Within an Application section is related to jobs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the content, ### Caveats section would be better than here.

@beliefer beliefer changed the title [SPARK-47795][DOCS] Supplement the doc of job schedule for K8S [SPARK-47795][KUBERNETES][DOCS] Supplement the doc of job schedule for K8S Apr 11, 2024
beliefer and others added 2 commits April 11, 2024 20:04
Co-authored-by: Kent Yao <yao@apache.org>
Co-authored-by: Kent Yao <yao@apache.org>
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @beliefer .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-47795][KUBERNETES][DOCS] Supplement the doc of job schedule for K8S [SPARK-47795][K8S][DOCS] Supplement the doc of job schedule for K8S Apr 11, 2024
@dongjoon-hyun
Copy link
Member

Let's wait for @yaooqinn 's final sign-off, @beliefer .

### Caveats

- In [standalone mode](spark-standalone.html), without explicitly setting `spark.executor.cores`, each executor will get all the available cores of a worker. In this case, when dynamic allocation enabled, spark will possibly acquire much more executors than expected. When you want to use dynamic allocation in [standalone mode](spark-standalone.html), you are recommended to explicitly set cores for each executor before the issue [SPARK-30299](https://issues.apache.org/jira/browse/SPARK-30299) got fixed.
- In [K8s mode](running-on-kubernetes.html), we can't using this feature by set `spark.shuffle.service.enabled` to `true` due to Spark on K8s doesn't support external shuffle service yet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In K8s mode, we cannot use this feature by setting spark.shuffle.service.enabled to true because Spark on K8s does not yet support the external shuffle service.

* **K8s:** The same as the situation with Yarn, please refer to the description of Yarn above. Furthermore,
Spark on K8s offers higher priority versions of spark.kubernetes.executor.limit.cores and
spark.kubernetes.executor.request.cores than spark.executor.cores. For more information, see the
[K8s Spark Properties](running-on-kubernetes.html#spark-properties).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark.kubernetes.executor.limit.cores and
spark.kubernetes.executor.request.cores than spark.executor.cores -> spark.kubernetes.executor.limit.cores and
spark.kubernetes.executor.request.cores than spark.executor.cores

@yaooqinn yaooqinn closed this in de20791 Apr 12, 2024
@yaooqinn
Copy link
Member

Merged to master

Thank you @beliefer @dongjoon-hyun @bjornjorgensen

@beliefer
Copy link
Contributor Author

@yaooqinn @dongjoon-hyun @bjornjorgensen Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants