[MINOR][PS] Use expression instead of a string column in Series.asof#46020
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][PS] Use expression instead of a string column in Series.asof#46020HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
zhengruifeng
approved these changes
Apr 12, 2024
Member
Author
|
Oh, it's a duplicate of #46018. Let me merge that instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use expression instead of a string column in Series.asof
Why are the changes needed?
It's better to use an expression over a string, and this particular case is a preparation of adding a DataFrame.asof in PySpark itself.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
It is a code cleanup
Was this patch authored or co-authored using generative AI tooling?
No.