[SPARK-47352][SQL] Fix Upper, Lower, InitCap collation awareness#46104
Closed
mihailomilosevic2001 wants to merge 14 commits intoapache:masterfrom
Closed
[SPARK-47352][SQL] Fix Upper, Lower, InitCap collation awareness#46104mihailomilosevic2001 wants to merge 14 commits intoapache:masterfrom
mihailomilosevic2001 wants to merge 14 commits intoapache:masterfrom
Conversation
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java
Outdated
Show resolved
Hide resolved
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java
Outdated
Show resolved
Hide resolved
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java
Outdated
Show resolved
Hide resolved
# Conflicts: # common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java
| assertInitCap("ÄBĆΔE", "UTF8_BINARY_LCASE", "Äbćδe"); | ||
| assertInitCap("aB世De", "UNICODE", "Ab世de"); | ||
| assertInitCap("ÄBĆΔE", "UNICODE", "Äbćδe"); | ||
| assertInitCap("aB世De", "UNICODE_CI", "Ab世De"); |
Contributor
Author
There was a problem hiding this comment.
@cloud-fan Should we just proceed with this ICU result? I am would expect Ab世de, but ICU seems to do conversion this way when we use UNICODE_CI.
cloud-fan
reviewed
Apr 22, 2024
| public static UTF8String execBinary(final UTF8String v) { | ||
| return v.toUpperCase(); | ||
| } | ||
| public static UTF8String execLowercase(final UTF8String v) { |
Contributor
There was a problem hiding this comment.
This is the same as execBinary?
Contributor
Author
There was a problem hiding this comment.
Merged these two to execUTF8.
cloud-fan
approved these changes
Apr 22, 2024
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for Locale aware expressions.
Why are the changes needed?
This is needed as some future collations might use different Locales then default.
Does this PR introduce any user-facing change?
Yes, we follow ICU implementations for collations that are non native.
How was this patch tested?
Tests for Upper, Lower and InitCap already exist.
Was this patch authored or co-authored using generative AI tooling?
No.