[SPARK-46810][DOCS][FOLLOWUP] Make some reference file links clickable#46105
Closed
panbingkun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-46810][DOCS][FOLLOWUP] Make some reference file links clickable#46105panbingkun wants to merge 1 commit intoapache:masterfrom
panbingkun wants to merge 1 commit intoapache:masterfrom
Conversation
panbingkun
changed the title
panbingkun
commented
Apr 17, 2024
|
|
||
| Fixing this will require renaming `SparkException.errorClass` to `SparkException.errorCondition` and making similar changes to `ErrorClassesJsonReader` and other parts of the codebase. We will address this in [SPARK-47429]. Until that is complete, we will have to live with the fact that a string like `DATATYPE_MISSING_SIZE` is called an "error condition" in our user-facing documentation but an "error class" in the code. | ||
|
|
||
| For more details, please see [SPARK-46810][SPARK-46810]. |
Contributor
Author
There was a problem hiding this comment.
After remove last [SPARK-46810], we can still click on it.
Contributor
Author
|
Before: After: |
Contributor
Author
nchammas
approved these changes
Apr 17, 2024
|
|
||
| Fixing this will require renaming `SparkException.errorClass` to `SparkException.errorCondition` and making similar changes to `ErrorClassesJsonReader` and other parts of the codebase. We will address this in [SPARK-47429]. Until that is complete, we will have to live with the fact that a string like `DATATYPE_MISSING_SIZE` is called an "error condition" in our user-facing documentation but an "error class" in the code. | ||
|
|
||
| For more details, please see [SPARK-46810][SPARK-46810]. |
Contributor
Author
|
also cc @dongjoon-hyun @HyukjinKwon |
HyukjinKwon
approved these changes
Apr 18, 2024
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr is following up #44902, to make some
reference files linksclickable.Why are the changes needed?
Convenient for developers to navigate directly when read this file
README.md.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.