[SPARK-47958][TESTS] Change LocalSchedulerBackend to notify scheduler of executor on start#46187
Closed
davintjong-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47958][TESTS] Change LocalSchedulerBackend to notify scheduler of executor on start#46187davintjong-db wants to merge 1 commit intoapache:masterfrom
davintjong-db wants to merge 1 commit intoapache:masterfrom
Conversation
cloud-fan
approved these changes
Apr 24, 2024
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing to call
reviveOfferson start (after the local executor is set up) so that the task scheduler knows about it. This matches behavior in CoarseGrainedSchedulerBackend, which will call an equivalent method on executor registration.Why are the changes needed?
When using LocalSchedulerBackend, the task scheduler will not know about the executor until a task is run, which can lead to unexpected behavior in tests.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Running existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.