Skip to content

Comments

[SPARK-47989][SQL] MsSQLServer: Fix the scope of spark.sql.legacy.mssqlserver.numericMapping.enabled#46223

Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-47361
Closed

[SPARK-47989][SQL] MsSQLServer: Fix the scope of spark.sql.legacy.mssqlserver.numericMapping.enabled#46223
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-47361

Conversation

@yaooqinn
Copy link
Member

What changes were proposed in this pull request?

This PR fixes the scope of spark.sql.legacy.mssqlserver.numericMapping.enabled

  • for the code part: it shouldn't affect GEOMETRY / GEOGRAPHY mapping
  • for the doc part: it should add TINYINT since 4.0.0

Why are the changes needed?

bugfix

Does this PR introduce any user-facing change?

Yes, setting spark.sql.legacy.mssqlserver.numericMapping.enabled=true used to disable GEOMETRY / GEOGRAPHY mapping, which is wrong.

How was this patch tested?

modified tests

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Apr 25, 2024
@yaooqinn yaooqinn changed the title [SPARK-47361][SQL] MsSQLServer: Fix the scope of spark.sql.legacy.mssqlserver.numericMapping.enabled [SPARK-47989][SQL] MsSQLServer: Fix the scope of spark.sql.legacy.mssqlserver.numericMapping.enabled Apr 25, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you @yaooqinn .

@yaooqinn yaooqinn deleted the SPARK-47361 branch April 26, 2024 08:40
@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants