[SPARK-47578][CORE] Migrate logWarning with variables to structured logging framework#46309
Closed
dtenedor wants to merge 17 commits intoapache:masterfrom
Closed
[SPARK-47578][CORE] Migrate logWarning with variables to structured logging framework#46309dtenedor wants to merge 17 commits intoapache:masterfrom
dtenedor wants to merge 17 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@gengliangwang thanks for a thorough review. I followed your instructions for every comment, and then just resolved them all to clean up the GitHub conversation history page. Please look again when ready! |
Member
|
@dtenedor the test failure looks relevant |
Contributor
Author
|
I will look at this relevant test failure: The test failure was: |
dongjoon-hyun
changed the title
Contributor
Author
|
@gengliangwang thanks for your review, responded to comments, please look again. |
gengliangwang
approved these changes
May 2, 2024
| verbose = true) | ||
| val output = lineBuffer.mkString("\n") | ||
| assert(output.contains(RPackageUtils.RJarDoc)) | ||
| assert(output.contains("Building R package")) |
Member
There was a problem hiding this comment.
This fix seems hacky. Is there a better fix for this one?
Contributor
Author
There was a problem hiding this comment.
You are right, this change is not too great.
I reverted the changes to RPackageUtils.scala and this file for now.
I will figure out how to get the R packages installed on my local machine and fix this file in a next step.
Contributor
Author
There was a problem hiding this comment.
Created https://issues.apache.org/jira/browse/SPARK-48122 to track it separately.
Contributor
Author
|
The two remaining test failures appear to be flaky/unrelated. |
Member
|
Thanks, merging to master |
sinaiamonkar-sai
pushed a commit
to sinaiamonkar-sai/spark
that referenced
this pull request
May 5, 2024
…ogging framework ### What changes were proposed in this pull request? Migrate logWarning with variables of the Spark Core module to structured logging framework. This transforms the logWarning entries of the following API ``` def logWarning(msg: => String): Unit ``` to ``` def logWarning(entry: LogEntry): Unit ``` ### Why are the changes needed? To enhance Apache Spark's logging system by implementing structured logging. ### Does this PR introduce _any_ user-facing change? Yes, Spark core logs will contain additional MDC ### How was this patch tested? Compiler and scala style checks, as well as code review. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46309 from dtenedor/spark-core-log-warn. Authored-by: Daniel Tenedorio <daniel.tenedorio@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate logWarning with variables of the Spark Core module to structured logging framework. This transforms the logWarning entries of the following API
to
Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
Yes, Spark core logs will contain additional MDC
How was this patch tested?
Compiler and scala style checks, as well as code review.
Was this patch authored or co-authored using generative AI tooling?
No