[SPARK-48056][PYTHON][CONNECT][FOLLOW-UP] Use assertEqual instead of assertEquals for Python 3.12#46377
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-48056][PYTHON][CONNECT][FOLLOW-UP] Use assertEqual instead of assertEquals for Python 3.12#46377dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
assertEqual instead of assertEquals for Python 3.12#46377dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
… assertEquals for Python 3.12
Member
Author
|
Let me merge this to recover the Python CI. |
Contributor
|
Wondering if we could get the linters or PR checks to catch this. |
Member
Author
|
Yes, it would be great like Scalastyle (Scala) and Checkstyle (Java). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of
This PR aims to use
assertEqualinstead ofassertEqualsfor Python 3.12.Why are the changes needed?
To recover Python CI,
From Python 3.12,
assertEqualsdoesn't exist.https://docs.python.org/3/library/unittest.html#assert-methods
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.