[SPARK-48263] Collate function support for non UTF8_BINARY strings#46574
Closed
nebojsa-db wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-48263] Collate function support for non UTF8_BINARY strings#46574nebojsa-db wants to merge 3 commits intoapache:masterfrom
nebojsa-db wants to merge 3 commits intoapache:masterfrom
Conversation
mihailomilosevic2001
approved these changes
May 14, 2024
Contributor
mihailomilosevic2001
left a comment
mihailomilosevic2001
left a comment
There was a problem hiding this comment.
LGTM except for few comments
...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala
Outdated
Show resolved
Hide resolved
nebojsa-db
changed the title
Contributor
Author
|
Please take a look :) @uros-db @stefankandic @nikolamand-db |
Contributor
|
btw, I'd say that this PR does introduce some user-facing changes - so I'd update the PR description to reflect this with more details |
nikolamand-db
approved these changes
May 14, 2024
cloud-fan
approved these changes
May 14, 2024
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
collate("xx", "") does not work when there is a config for default collation set which configures non UTF8_BINARY collation as default.
Why are the changes needed?
Fixing the compatibility issue with default collation config and collate function.
Does this PR introduce any user-facing change?
Customers will be able to execute collation(, ) function even when default collation config is configured to some other collation than UTF8_BINARY. We are expanding the surface area for cx.
How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No.