[SPARK-48272][SQL][PYTHON][CONNECT] Add function timestamp_diff#46576
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-48272][SQL][PYTHON][CONNECT] Add function timestamp_diff#46576zhengruifeng wants to merge 2 commits intoapache:masterfrom
timestamp_diff#46576zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
zhengruifeng
commented
May 14, 2024
| new BloomFilterAggregate(children(0), children(1), children(2)) | ||
| .toAggregateExpression()) | ||
|
|
||
| case "timestampdiff" if fun.getArgumentsCount == 3 => |
Contributor
Author
There was a problem hiding this comment.
move it out of PS(Pandas API on Spark)-specific functions
xinrong-meng
approved these changes
May 14, 2024
Member
|
LGTM, thank you! |
HyukjinKwon
approved these changes
May 15, 2024
Contributor
Author
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add function
timestamp_diff, by reusing existing protospark/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Lines 1971 to 1974 in c4df12c
Why are the changes needed?
this method is missing in dataframe API due to it is not in
FunctionRegistryDoes this PR introduce any user-facing change?
yes, new method
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
no