[SPARK-48412][PYTHON] Refactor data type json parse #46733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this just refactoring or causing any behaviour change? |
HyukjinKwon
reviewed
May 24, 2024
| # 2, DecimalType can be parsed by both mapping ('decimal') and regex ('decimal(10, 2)'); | ||
| # 3, CalendarIntervalType is not an atomic type, but can be mapped by 'interval'; | ||
| _all_mappable_types: Dict[str, Type[DataType]] = { | ||
| "string": StringType, |
Member
There was a problem hiding this comment.
Hm, why don't we call typeName()?
Contributor
Author
There was a problem hiding this comment.
There is another issue: existing typeName are not consistent with the Scala side.
I want to fix it in a separate PR.
Contributor
Author
this is just refactoring |
HyukjinKwon
approved these changes
May 24, 2024
Contributor
Author
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor data type json parse
Why are the changes needed?
the
_all_atomic_typescauses confusions:jsonValueinstead oftypeName(and so it causes thetypeNamenot consistent with Scala, will fix in separate PR);YearMonthIntervalType);VarcharTypewhich has to be excluded here and there)Does this PR introduce any user-facing change?
no
How was this patch tested?
ci, added tests
Was this patch authored or co-authored using generative AI tooling?
no