[SPARK-48425][INFRA][FOLLOWUP] copy spark connect release tarballs #46769
Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-48425][INFRA][FOLLOWUP] copy spark connect release tarballs #46769cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
May 28, 2024
Member
|
Merged to master. |
cloud-fan
commented
May 28, 2024
| cp pyspark-* "svn-spark/${DEST_DIR_NAME}-bin/" | ||
| cp SparkR_* "svn-spark/${DEST_DIR_NAME}-bin/" | ||
| cp spark* "svn-spark/${DEST_DIR_NAME}-bin/" | ||
| cp pyspark* "svn-spark/${DEST_DIR_NAME}-bin/" |
Contributor
Author
There was a problem hiding this comment.
note: only pyspark tarballs have the issue, but I applied the fix to all of them so that it's more reliable.
HyukjinKwon
pushed a commit
that referenced
this pull request
May 28, 2024
### What changes were proposed in this pull request? This is a followup of #46769 to fix a mistake. The release scripts use a base `spark` folder to build tarballs and it shouldn't be copied with the tarballs. ### Why are the changes needed? fix mistake ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manual ### Was this patch authored or co-authored using generative AI tooling? no Closes #46771 from cloud-fan/script. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #46751 . Now the spark connect tarball is named
pyspark_connect..., and we need to update the release scripts as well.Why are the changes needed?
fix release scripts
Does this PR introduce any user-facing change?
no
How was this patch tested?
manual
Was this patch authored or co-authored using generative AI tooling?
no