[SPARK-48464][SQL][TESTS] Use withSQLConf in tests: Refactor SQLConfSuite and StatisticsSuite#46796
Closed
amaliujia wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-48464][SQL][TESTS] Use withSQLConf in tests: Refactor SQLConfSuite and StatisticsSuite#46796amaliujia wants to merge 1 commit intoapache:masterfrom
amaliujia wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
May 30, 2024
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM but are there a lot of instances left to fix? I think it's better to do them in batch
HyukjinKwon
changed the title
Contributor
Author
|
@HyukjinKwon sure I will try to increase the size of such PR. |
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use withSQLConf in tests when it is appropriate.
Why are the changes needed?
Enforce good practice for setting config in test cases.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
NO