[SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework#46815
Closed
dtenedor wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework#46815dtenedor wants to merge 1 commit intoapache:masterfrom
dtenedor wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Member
There was a problem hiding this comment.
@dtenedor I planned to skip this one since we disabled the structured logging for sparkR shell in https://github.com/apache/spark/pull/46383/files#diff-f8564df81d845c0cd2f621bc2ed22761cbf9731f28cb2828d9cbd0491f4e7584R74.
But since you made the changes, we can still merge this one
Contributor
Author
There was a problem hiding this comment.
Thanks, and sorry for missing it :)
gengliangwang
approved these changes
May 31, 2024
Member
|
Thanks, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate logging with variables of the Spark
RPackageUtilsmodule to structured logging framework. This transforms the log* entries of APIs like this:to
Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
Yes, Spark core logs will contain additional MDC
How was this patch tested?
Compiler and scala style checks, as well as code review.
Was this patch authored or co-authored using generative AI tooling?
Brief but appropriate use of GitHub copilot