[SPARK-48584][SQL] Perf improvement for unescapePathName#46938
Closed
yaooqinn wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-48584][SQL] Perf improvement for unescapePathName#46938yaooqinn wants to merge 3 commits intoapache:masterfrom
yaooqinn wants to merge 3 commits intoapache:masterfrom
Conversation
yaooqinn
changed the title
Member
Author
|
cc @dongjoon-hyun @cloud-fan @LuciferYang @JoshRosen thanks |
Contributor
|
Could you provide some micro benchmark? |
Member
Author
What do you mean by some micro benchmark? Are sql/catalyst/benchmarks/EscapePathBenchmark-results.txt and sql/catalyst/benchmarks/EscapePathBenchmark-jdk21-results.txt not sufficient ? |
Contributor
|
Oh, I see. |
Contributor
|
It seems that there is a typo in the pr description: chararaters -> characters |
Member
Author
|
Thank you @LuciferYang |
LuciferYang
approved these changes
Jun 12, 2024
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM
Thanks @yaooqinn
beliefer
reviewed
Jun 12, 2024
| } | ||
| var plaintextEndIdx = path.indexOf('%') | ||
| val length = path.length | ||
| if (plaintextEndIdx == -1 || plaintextEndIdx + 2 > path.length) { |
Contributor
There was a problem hiding this comment.
How about if (plaintextEndIdx == -1 || plaintextEndIdx + 2 > path.length || path.lastIndexOf('%') == 0) ?
Member
Author
There was a problem hiding this comment.
|| path.lastIndexOf('%')
I'm sorry, I'm having a little trouble understanding your suggestion. Can you please clarify?
Member
Author
|
Thank you @LuciferYang, I added a nit in the last commit and passed the test locally, so I didn't wait for the CI. Merged to master |
beliefer
added a commit
that referenced
this pull request
Jun 13, 2024
### What changes were proposed in this pull request? This PR follows up #46938 and improve the `unescapePathName`. ### Why are the changes needed? Improve the `unescapePathName` by cut off slow path. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #46957 from beliefer/SPARK-48584_followup. Authored-by: beliefer <beliefer@163.com> Signed-off-by: beliefer <beliefer@163.com>
FelixYBW
pushed a commit
to apache/incubator-gluten
that referenced
this pull request
Feb 20, 2025
…ue (#8793) GlutenURLDecoder.java is copied from OpenJDK and it's under GPL v2 which belongs to Category X, we can't have it in Apache Releases. URLDecoder decode/encode is not fully compatible with the Hive catalog path escaping/unescaping, which Spark also follows. Besides, apache/spark#46938 has improved unescapePathName's speed at the Spark side by ~10x. So This PR also helps gluten gain perf which handles datasets w/ large partition numbers.
kevinw66
pushed a commit
to kevinw66/incubator-gluten
that referenced
this pull request
Mar 3, 2025
…ue (apache#8793) GlutenURLDecoder.java is copied from OpenJDK and it's under GPL v2 which belongs to Category X, we can't have it in Apache Releases. URLDecoder decode/encode is not fully compatible with the Hive catalog path escaping/unescaping, which Spark also follows. Besides, apache/spark#46938 has improved unescapePathName's speed at the Spark side by ~10x. So This PR also helps gluten gain perf which handles datasets w/ large partition numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves perf for unescapePathName with algorithms briefly described as:
position > path.length-2, we return the original identity instead of creating a new StringBuilder to append char by charplaintextStartIdxwhich starts from 0 and then points to the next char after resolving%xx, andplaintextEndIdxwhich points to the next'%'.plaintextStartIdxmoves toplaintextEndIdx + 3if%xxis valid, or moves toplaintextEndIdx + 1if%xxis invalid.Why are the changes needed?
performance improvement for hotspots
Does this PR introduce any user-facing change?
no
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
no