[SPARK-48621][SQL] Fix Like simplification in Optimizer for collated strings#46976
Closed
uros-db wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-48621][SQL] Fix Like simplification in Optimizer for collated strings#46976uros-db wants to merge 3 commits intoapache:masterfrom
uros-db wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
adding @mihailom-db @stevomitric for review |
yaooqinn
reviewed
Jun 14, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLRegexpSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Jun 14, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLRegexpSuite.scala
Outdated
Show resolved
Hide resolved
mihailomilosevic2001
approved these changes
Jun 14, 2024
yaooqinn
approved these changes
Jun 14, 2024
Member
|
Merged to master, thanks @uros-db @mihailom-db |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable
LikeSimplificationoptimizer rule for collated strings.Why are the changes needed?
Optimize how
Likeexpression works with collated strings and ensure collation awareness when replacingLikeexpressions withStartsWith/EndsWith/Contains/EqualTounder special conditions.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New e2e sql tests in
CollationSQLRegexpSuite.Was this patch authored or co-authored using generative AI tooling?
No.