[SPARK-48693][SQL] Simplify and unify toString of Invoke and StaticInvoke#47066
Closed
yaooqinn wants to merge 10 commits intoapache:masterfrom
Closed
[SPARK-48693][SQL] Simplify and unify toString of Invoke and StaticInvoke#47066yaooqinn wants to merge 10 commits intoapache:masterfrom
yaooqinn wants to merge 10 commits intoapache:masterfrom
Conversation
Member
Author
|
cc @cloud-fan @LuciferYang @dongjoon-hyun @HyukjinKwon thanks |
HyukjinKwon
reviewed
Jun 25, 2024
...r/connect/common/src/test/resources/query-tests/explain-results/function_aes_decrypt.explain
Show resolved
Hide resolved
cloud-fan
approved these changes
Jun 25, 2024
Member
Author
|
Merged to master, thank you all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
StaticInvokeclass is used extensively byRuntimeReplacableexpressions, due to its ugly string representation, a plan with multiple or nestedStaticInvokeis hard to read.This PR overrides
StaticInvoke's toString method to improve its readability.In contrast, the
Invoke's toString is overly simple, losing its child's string representations.Why are the changes needed?
improve plan readability and consistency
Does this PR introduce any user-facing change?
Yes, a plan containing
StaticInvokewill change its string representation.How was this patch tested?
existing modified tests
Was this patch authored or co-authored using generative AI tooling?
no