[SPARK-48705][PYTHON] Explicitly use worker_main when it starts with pyspark#47077
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-48705][PYTHON] Explicitly use worker_main when it starts with pyspark#47077HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
zhengruifeng
approved these changes
Jun 26, 2024
Member
Author
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use worker modules when it starts with
pyspark.Why are the changes needed?
Because now daemon uses worker module from the first argument, it could break if users are using custom workers with providing parameters. They aren't actual API but it is better to be more strict on the argument provided.
Here is an example of sentry-python
Does this PR introduce any user-facing change?
Yes, it recovers the support of sentry-python.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.