Skip to content

[SPARK-49384][BUILD] Upgrade rocksdbjni to 9.5.2#47207

Closed
panbingkun wants to merge 6 commits intoapache:masterfrom
panbingkun:rocksdbjni_upgrade
Closed

[SPARK-49384][BUILD] Upgrade rocksdbjni to 9.5.2#47207
panbingkun wants to merge 6 commits intoapache:masterfrom
panbingkun:rocksdbjni_upgrade

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jul 4, 2024

What changes were proposed in this pull request?

The pr aims to upgrade rocksdbjni from 9.2.1 to 9.5.2.

Why are the changes needed?

The full release notes as follows:
https://github.com/facebook/rocksdb/releases/tag/v9.5.2
https://github.com/facebook/rocksdb/releases/tag/v9.4.0
https://github.com/facebook/rocksdb/releases/tag/v9.3.1

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jul 4, 2024
@panbingkun
Copy link
Contributor Author

Recently, there has been an upgrade related to rocksdbjni. This PR will be held for now.
Let's test it first to verify its stability and performance

@panbingkun panbingkun changed the title [ONLY TEST][HOLD] Upgrade rocksdbjni to 9.3.1 [ONLY TEST][HOLD] Upgrade rocksdbjni to 9.4.0 Jul 14, 2024
@LuciferYang
Copy link
Contributor

Has there been any new progress on this one

@panbingkun
Copy link
Contributor Author

Has there been any new progress on this one

Let's wait a little longer, I think version 9.5 should be released soon
image
Thanks.

@panbingkun panbingkun changed the title [ONLY TEST][HOLD] Upgrade rocksdbjni to 9.4.0 [ONLY TEST][HOLD] Upgrade rocksdbjni to 9.5.2 Aug 25, 2024
@panbingkun panbingkun changed the title [ONLY TEST][HOLD] Upgrade rocksdbjni to 9.5.2 [SPARK-49384][BUILD] Upgrade rocksdbjni to 9.5.2 Aug 26, 2024
@panbingkun
Copy link
Contributor Author

panbingkun commented Aug 26, 2024

The benchmark: StateStoreBasicOperationsBenchmark
JDK17: https://github.com/panbingkun/spark/actions/runs/10552245823
JDK21: https://github.com/panbingkun/spark/actions/runs/10552248981

@github-actions github-actions bot added the SQL label Aug 26, 2024
@panbingkun panbingkun marked this pull request as ready for review August 26, 2024 03:28
@panbingkun
Copy link
Contributor Author

cc @LuciferYang @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @panbingkun .
Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants