[SPARK-48813][SQL][DOCS] Add a notice that mariadb protocol does not apply when the database is MariaDB#47220
Closed
wayneguow wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-48813][SQL][DOCS] Add a notice that mariadb protocol does not apply when the database is MariaDB#47220wayneguow wants to merge 2 commits intoapache:masterfrom
mariadb protocol does not apply when the database is MariaDB#47220wayneguow wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Gentle ping @HyukjinKwon, currently I am just adding a notice in the docs to give some help for users. Do we need to further throw an exception directly for the |
Member
|
Since we don't have MariaDBDialect to support |
Contributor
Author
|
@yaooqinn Thank you for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add a notice that
mariadbprotocol does not apply when the database isMariaDBinsql-data-sources-jdbc.md.Why are the changes needed?
MariaDBDialectis not implemented currently. If the user uses thejdbc:mariadbprotocol, an error will occur，as described in https://issues.apache.org/jira/browse/SPARK-25013. It's better to add a notice that when users get an error, they can get help from the documentation.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?