Skip to content

[SPARK-48893][SQL][PYTHON][DOCS] Add some examples for linearRegression built-in functions#47343

Closed
wayneguow wants to merge 5 commits intoapache:masterfrom
wayneguow:regr_series
Closed

[SPARK-48893][SQL][PYTHON][DOCS] Add some examples for linearRegression built-in functions#47343
wayneguow wants to merge 5 commits intoapache:masterfrom
wayneguow:regr_series

Conversation

@wayneguow
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to add some extra examples for linearRegression built-in functions.

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA and Manual testing for new examples.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Jul 14, 2024
@wayneguow wayneguow marked this pull request as draft July 15, 2024 01:45
@wayneguow wayneguow marked this pull request as ready for review July 15, 2024 08:49
@LuciferYang
Copy link
Contributor

fine to me, but if you can help refine the Python doc for the corresponding function in builtin.py, that would be even better.

@wayneguow
Copy link
Contributor Author

Updated it. Also cc @zhengruifeng @allisonwang-db for the python side.

@wayneguow wayneguow changed the title [SPARK-48893][SQL][DOCS] Add some examples for linearRegression built-in functions [SPARK-48893][SQL][PYTHON][DOCS] Add some examples for linearRegression built-in functions Jul 18, 2024
@LuciferYang
Copy link
Contributor

also cc @HyukjinKwon

Copy link
Contributor

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! cc @zhengruifeng to double check the examples

@wayneguow
Copy link
Contributor Author

cc @zhengruifeng Updated as suggested, please take a look when you have time. Thanks~

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang
Copy link
Contributor

Merged into master. Thanks @wayneguow @zhengruifeng and @allisonwang-db

@wayneguow wayneguow deleted the regr_series branch February 11, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants