[SPARK-48843][FOLLOWUP] Adding a PySpark test. #47653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with BindParameters. Executes a query where parameter binding was wrapped in a Limit node.
| assert cls.spark is not None | ||
| assert cls.spark._jvm.SparkSession.getDefaultSession().isDefined() | ||
|
|
||
| def test_wrapping_plan_in_limit_node(self): |
Contributor
There was a problem hiding this comment.
Any reason why we need a PySpark specific test for this?
Contributor
There was a problem hiding this comment.
spark.sql has no difference between Scala Spark and Python Spark, otherwise we will need to duplicate a lot of tests in pyspark.
Contributor
Author
|
Cancelling this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR contains a PySpark test that is checking parameter binding wrapped within Limit node that has caused an infinite loop before #47271 bug fix. This test shall fail should the bug be accidentally reintroduced.
Why are the changes needed?
PySpark test complements Scala test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually ran the test.
Was this patch authored or co-authored using generative AI tooling?
No.