Skip to content

[SPARK-49114][SS][FOLLOWUP] Add missing error classes into json definition file#47690

Closed
riyaverm-db wants to merge 1 commit intoapache:masterfrom
riyaverm-db:sub-categorize-cannot-load-state-store-errors-follow-up
Closed

[SPARK-49114][SS][FOLLOWUP] Add missing error classes into json definition file#47690
riyaverm-db wants to merge 1 commit intoapache:masterfrom
riyaverm-db:sub-categorize-cannot-load-state-store-errors-follow-up

Conversation

@riyaverm-db
Copy link
Contributor

@riyaverm-db riyaverm-db commented Aug 9, 2024

What changes were proposed in this pull request?

Follow up to SPARK-49114 (#47616). The PR added sub-categories of "cannot load state store errors", but it missed to add definition of error class into error-conditions.json JSON file.

Why are the changes needed?

Newly added error classes from #47616 will be dangling ones without this PR.

Does this PR introduce any user-facing change?

Yes, user will see the detailed error class to identify the issue better for the case of "cannot load state store" error.

How was this patch tested?

N/A

Was this patch authored or co-authored using generative AI tooling?

No.

@riyaverm-db
Copy link
Contributor Author

@HeartSaVioR requesting final review

@HyukjinKwon HyukjinKwon changed the title [SPARK-49114][FOLLOWUP] Sub-categorize cannot load state store errors [SPARK-49114][SS][FOLLOWUP] Sub-categorize cannot load state store errors Aug 11, 2024
@HyukjinKwon
Copy link
Member

Mind updating PR description? How does it affect the end users?

@HeartSaVioR HeartSaVioR changed the title [SPARK-49114][SS][FOLLOWUP] Sub-categorize cannot load state store errors [SPARK-49114][SS][FOLLOWUP] Add missing error classes into json definition file Aug 12, 2024
@HeartSaVioR
Copy link
Contributor

HeartSaVioR commented Aug 12, 2024

@HyukjinKwon
This adds a missing error classes into json definition file. There was a PR which added error classes into the codebase but missed to add them in error class json file. We couldn't catch this from testing as it's non-trivial to arbitrarily trigger the condition.

I updated the PR description. Hope this clarifies the rationale of this PR.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants