[SPARK-49183][SQL][FOLLOWUP][3.5] Fix compilation#47722
Closed
cloud-fan wants to merge 2 commits intoapache:branch-3.5from
Closed
[SPARK-49183][SQL][FOLLOWUP][3.5] Fix compilation#47722cloud-fan wants to merge 2 commits intoapache:branch-3.5from
cloud-fan wants to merge 2 commits intoapache:branch-3.5from
Conversation
yaooqinn
approved these changes
Aug 12, 2024
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Aug 12, 2024
| import java.sql.Timestamp | ||
| import java.time.{Duration, LocalDate, Period} | ||
| import java.util | ||
| import java.{util => jutil} |
Member
There was a problem hiding this comment.
Could you fix the import order, @cloud-fan ?
[error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:22:0: java. is in wrong order relative to java.time..
Member
There was a problem hiding this comment.
Nvm. I. updated the order.
$ dev/scalastyle
Using SPARK_LOCAL_IP=localhost
Scalastyle checks passed.
Member
|
Merged to branch-3.5 to recover CIs and unblock other PRs. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 12, 2024
### What changes were proposed in this pull request? fix compilation error caused by #47684 . Seems scala 2.12 has some subtle differences in the import priority. ### Why are the changes needed? N/A ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? pass compilation ### Was this patch authored or co-authored using generative AI tooling? no Closes #47722 from cloud-fan/fix. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix compilation error caused by #47684 . Seems scala 2.12 has some subtle differences in the import priority.
Why are the changes needed?
N/A
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
pass compilation
Was this patch authored or co-authored using generative AI tooling?
no