Skip to content

[SPARK-49267][SQL][TESTS] Add collation support unit tests for StringTranslate#47729

Closed
uros-db wants to merge 1 commit intoapache:masterfrom
uros-db:unit-tests-5
Closed

[SPARK-49267][SQL][TESTS] Add collation support unit tests for StringTranslate#47729
uros-db wants to merge 1 commit intoapache:masterfrom
uros-db:unit-tests-5

Conversation

@uros-db
Copy link
Contributor

@uros-db uros-db commented Aug 12, 2024

What changes were proposed in this pull request?

Add collation support unit tests for:

  • StringTranslate

This PR contains test-only changes, providing additional test coverage for cases such as:

  • case and accent variation
  • one-to-many case mapping
  • conditional case mapping
  • surrogate pairs
  • etc.

Why are the changes needed?

Improve collation support testing.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

New unit tests in CollationSupportSuite.

Was this patch authored or co-authored using generative AI tooling?

Yes.

@github-actions github-actions bot added the SQL label Aug 12, 2024
@uros-db uros-db changed the title [SPARK-49213][SQL] Add collation support unit tests for StringTranslate [SPARK-49213][SQL][TESTS] Add collation support unit tests for StringTranslate Aug 12, 2024
@uros-db uros-db changed the title [SPARK-49213][SQL][TESTS] Add collation support unit tests for StringTranslate [WIP][SPARK-49213][SQL][TESTS] Add collation support unit tests for StringTranslate Aug 13, 2024
@uros-db uros-db changed the title [WIP][SPARK-49213][SQL][TESTS] Add collation support unit tests for StringTranslate [SPARK-49213][SQL][TESTS] Add collation support unit tests for StringTranslate Aug 14, 2024
Copy link
Contributor Author

@uros-db uros-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all checks good, marking as ready for review

Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve collation support testing.

@uros-db Could you provide more details in PR's description: what you improved. and why (additional test coverage, corner cases and negative cases, and so on).

@uros-db uros-db requested a review from MaxGekk August 16, 2024 09:04
@uros-db uros-db changed the title [SPARK-49213][SQL][TESTS] Add collation support unit tests for StringTranslate [SPARK-49266][SQL][TESTS] Add collation support unit tests for StringTranslate Aug 16, 2024
@uros-db uros-db changed the title [SPARK-49266][SQL][TESTS] Add collation support unit tests for StringTranslate [SPARK-49267][SQL][TESTS] Add collation support unit tests for StringTranslate Aug 16, 2024
@MaxGekk
Copy link
Member

MaxGekk commented Aug 20, 2024

+1, LGTM. Merging to master.
Thank you, @uros-db.

@MaxGekk MaxGekk closed this in 4be1ddc Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants