[SPARK-49225][SQL][CONNECT] Add ColumnNode sql & normalize #47745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
commented
Aug 13, 2024
|
|
||
|
|
||
| /** Return the class name of the given object, removing all dollar signs */ | ||
| def getFormattedClassName(obj: AnyRef): String = { |
Contributor
Author
There was a problem hiding this comment.
Moved because I needed this functionality in sql/api.
HyukjinKwon
approved these changes
Aug 13, 2024
Contributor
Author
|
Merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the ColumnNode.sql and ColumnNode.normalize functions. Both are needed when we integrate ColumnNode in the Column. This PR also improves some of the UDF handling.
Why are the changes needed?
ColumnNode needs to support all the functionality needed by Column.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
(Improved) existing tests, and added a test suite for sql and normalize.
Was this patch authored or co-authored using generative AI tooling?
No.