[SPARK-49017][SQL][3.5] Insert statement fails when multiple parameters are being used#47814
Closed
mihailomilosevic2001 wants to merge 1 commit intoapache:branch-3.5from
Closed
Conversation
Contributor
Author
|
@MaxGekk Opened this backport PR. |
MaxGekk
requested changes
Aug 20, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
@mihailom-db Could you add the original PR description (additionally to the ref to the original PR) and remove (Backport) and add the [3.5] tag to PR's title.
mihailomilosevic2001
changed the title
mihailomilosevic2001
changed the title
MaxGekk
changed the title
MaxGekk
approved these changes
Aug 20, 2024
Member
|
+1, LGTM. Merging to 3.5. |
MaxGekk
pushed a commit
that referenced
this pull request
Aug 20, 2024
…rs are being used ### What changes were proposed in this pull request? Fix for multiple parameters support. This PR is a backport of #47501. ### Why are the changes needed? The use of multiple parameters with identifiers were broken ### Does this PR introduce _any_ user-facing change? Yes, look at tests. ### How was this patch tested? New tests added to ParametersSuite. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47814 from mihailom-db/fixParametersBackport. Authored-by: Mihailo Milosevic <mihailo.milosevic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix for multiple parameters support.
This PR is a backport of #47501.
Why are the changes needed?
The use of multiple parameters with identifiers were broken
Does this PR introduce any user-facing change?
Yes, look at tests.
How was this patch tested?
New tests added to ParametersSuite.
Was this patch authored or co-authored using generative AI tooling?
No.