[SPARK-49339][INFRA] Use setup-minikube GitHub Action

[TQJADE]

What changes were proposed in this pull request?

Use Minikube action

Why are the changes needed?

This is introduced in Minikube doc:

• https://minikube.sigs.k8s.io/docs/tutorials/setup_minikube_in_github_actions/
• https://github.com/marketplace/actions/setup-minikube

Does this PR introduce any user-facing change?

No, this is a infra change.

How was this patch tested?

Pass the CIs and check the CI log on this PR.

Was this patch authored or co-authored using generative AI tooling?

No.

[dongjoon-hyun]

+1, LGTM (Pending CIs). Thank you, @TQJADE

[bjornjorgensen]

why have you pinned the version to 0.0.18 and why not @latest

with this curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 we had the latest always but now it its pinned.

[dongjoon-hyun]

To @bjornjorgensen , we use pinned GitHub Action always.

$ git grep setup .github/workflows/build_and_test.yml
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:      uses: actions/setup-python@v5
.github/workflows/build_and_test.yml:        uses: docker/setup-qemu-action@v3
.github/workflows/build_and_test.yml:        uses: docker/setup-buildx-action@v3
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:        # The followings are also used by `r-lib/actions/setup-r` to avoid
.github/workflows/build_and_test.yml:      uses: bufbuild/buf-setup-action@v1
.github/workflows/build_and_test.yml:      uses: actions/setup-python@v5
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:      uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:        uses: actions/setup-java@v4
.github/workflows/build_and_test.yml:        uses: actions/setup-node@v4

In addition, the GitHub Action version is irrelevant to the Minikube version. According to the log, it downloads the latest Minikube 1.33.1 like the picture.

[dongjoon-hyun]

It's the same like setup-java.

[TQJADE]

Currently from market place: https://github.com/marketplace/actions/setup-minikube 0.0.18 is the latest.
I think pinning a version will be better to stabilized the test.

[pan3793]

The PR GHA runs in the contributor's repo, is this action allowed by ASF?
https://infra.apache.org/github-actions-policy.html

[dongjoon-hyun]

Yes, this is allowed, @pan3793 . I asked the same question exactly when @TQJADE contributed this to Apache Spark Kubernetes Operator first. I asked to spin off this separately at that time and verified that it's running fine. After that, I asked her to contribute here together.

• [SPARK-49214] Add e2e test in operator workflow spark-kubernetes-operator#77
• [SPARK-49331] Use setup-minikube GitHub Action spark-kubernetes-operator#82

[pan3793]

@dongjoon-hyun thanks for information, it's fine then.

[dongjoon-hyun]

Thank you, @pan3793 .

[dongjoon-hyun]

For the record, there is only one irrelevant failure and it's a known flaky one.

[info] *** 1 SUITE ABORTED ***
[error] Error: Total 4127, Failed 0, Errors 1, Passed 4126, Ignored 8, Canceled 2
[error] Error during tests:
[error] 	org.apache.spark.util.collection.SorterSuite

[bjornjorgensen]

from https://github.com/medyagh/setup-minikube/blob/master/action.yml

kubernetes-version:
    description: 'Choose a specific version of Kubernetes, "stable" for the latest stable build, or "latest" for the latest development build'
    required: false
    default: ''

should be pin latest her?

EDIT:

required: false
so we don't need it.

[dongjoon-hyun]

Ya, thank you for double-checking, @bjornjorgensen . We don't need that.

Merged to master~

[dongjoon-hyun]

Thank you again, @TQJADE , @bjornjorgensen , @pan3793 .